Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change markdown parser #5

Closed
ghost opened this issue Jan 29, 2019 · 2 comments
Closed

Change markdown parser #5

ghost opened this issue Jan 29, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 29, 2019

currently kramdown is the default parser:

motyl/bin/motyl

Lines 16 to 20 in 4585fff

require 'date'
require 'fileutils'
require 'kramdown'
require 'mustache'
require 'yaml'

however this can cause some issues, as kramdown is quite different from
CommonMark/GFM:

and the kramdown author is unwilling or unable to fix these issues, for several
years now. after some hand wringing i discovered that a proper commonmark
implementation is available:

https://github.com/jekyll/jekyll-commonmark

@fcambus
Copy link
Owner

fcambus commented Jan 29, 2019

No, those are non issues for Motyl.

Kramdown was selected because it is a pure-Ruby implementation with zero dependencies.

There is nothing to gain by switching to another Gem with a dependency on a C library, as it will cause packaging issues for operating systems.

@fcambus fcambus closed this as completed Jan 29, 2019
@ghost
Copy link
Author

ghost commented Jan 29, 2019

there is nothing to gain?

certainly there is else i wouldnt have posted this issue

what is to gain is a commonmark compliant converter

i respect your reason to close but perhaps dont mislead any who might visit this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant