Convolution3D: do not fix input_shape. (Fixes #5108.) #5177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use a single
Convolution3D
layer with different input sizes (see #5108). The behaviour is then similar to that ofConvolution2D
, which also doesn't fix the input shape.Potential downside: not providing the input shape makes it slightly harder for Theano to optimise the convolution. If the input shape is known, Theano will sometimes choose to use
GpuCorrMM_gradWeights
instead of theGpuCorrMM
if this is faster, for example. In practice, however, Theano will mostly use the cuDNN version anyway and this should cause problems.