Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository namespace #14

Closed
acoburn opened this issue Jan 22, 2015 · 7 comments
Closed

Repository namespace #14

acoburn opened this issue Jan 22, 2015 · 7 comments

Comments

@acoburn
Copy link
Contributor

acoburn commented Jan 22, 2015

@ajs6f mentioned wanting a clean repository namespace document. When I looked through the fedora repository.rdf document, there are a few items I'm wondering about.

@escowles
Copy link
Contributor

@acoburn: I'm fine with updating the classes to all be capitalized, and removing the isDeep property now that locks have been removed.

For the repository.* properties, these are generated from Modeshape configuration property names (see https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-kernel-impl/src/main/java/org/fcrepo/kernel/impl/rdf/impl/RootRdfContext.java#L90). There was a Pivotal ticket to make these camelCase, but I don't see a JIRA ticket for that. So we should make sure we update the generation of those triples when we update the ontology.

@awoods
Copy link

awoods commented Jan 27, 2015

@escowles, I am not seeing the Pivotal ticket that you reference.
https://www.pivotaltracker.com/n/projects/684825

In any case, let's clean up the ontology and related usages in the code.

@escowles
Copy link
Contributor

@awoods I think the ticket I was thinking of is:

https://www.pivotaltracker.com/n/projects/684825/stories/75047684

Changing the names to camelCase was the second item, but we didn't actually do that (I thought we made a separate ticket for that, but I don't see it). Agreed that we should clean up the ontology, including updating the format of the repository config predicates to camelCase.

@acoburn
Copy link
Contributor Author

acoburn commented Jan 27, 2015

@escowles what do you think about removing the repository:hasLockToken property?

@escowles
Copy link
Contributor

@acoburn Since we've removed locking from the REST API, I definitely think we should remove the hasLockToken property.

@awoods
Copy link

awoods commented Jan 27, 2015

👍 to dropping the lock property.

@awoods
Copy link

awoods commented Jan 27, 2015

Tracking with: https://jira.duraspace.org/browse/FCREPO-1309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants