Skip to content

Commit

Permalink
Rename dynamic build properties for clarity
Browse files Browse the repository at this point in the history
The build-helper-maven-plugin is used to generate properties for dynamic
port configuration. This commit marks these properties with the word
`dynamic` to highlight that fact, e.g. `fcrepo.dynamic.test.port`.
  • Loading branch information
claussni committed Feb 6, 2015
1 parent 07ef675 commit 967a5e6
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
22 changes: 11 additions & 11 deletions pom.xml
Expand Up @@ -127,11 +127,11 @@
<artifactId>build-helper-maven-plugin</artifactId>
<configuration>
<portNames>
<portName>fcrepo.test.port</portName>
<portName>fcrepo.dynamic.test.port</portName>
<!-- reserves the stop port for jetty-maven-plugin -->
<portName>jetty.port.stop</portName>
<portName>fcrepo.jms.port</portName>
<portName>fcrepo.stomp.port</portName>
<portName>jetty.dynamic.stop.port</portName>
<portName>fcrepo.dynamic.jms.port</portName>
<portName>fcrepo.dynamic.stomp.port</portName>
</portNames>
</configuration>
</plugin>
Expand Down Expand Up @@ -169,22 +169,22 @@
<configuration>
<connectors>
<connector implementation="org.eclipse.jetty.server.nio.SelectChannelConnector">
<port>${fcrepo.test.port}</port>
<port>${fcrepo.dynamic.test.port}</port>
<maxIdleTime>60000</maxIdleTime>
</connector>
</connectors>
<daemon>true</daemon>
<stopPort>${jetty.port.stop}</stopPort>
<stopPort>${jetty.dynamic.stop.port}</stopPort>

<systemProperties>
<systemProperty>
<name>fcrepo.jms.port</name>
<value>${fcrepo.jms.port}</value>
<name>fcrepo.dynamic.jms.port</name>
<value>${fcrepo.dynamic.jms.port}</value>
</systemProperty>

<systemProperty>
<name>fcrepo.stomp.port</name>
<value>${fcrepo.stomp.port}</value>
<name>fcrepo.dynamic.stomp.port</name>
<value>${fcrepo.dynamic.stomp.port}</value>
</systemProperty>

<systemProperty>
Expand Down Expand Up @@ -229,7 +229,7 @@
<goal>stop</goal>
</goals>
<configuration>
<stopPort>${jetty.port.stop}</stopPort>
<stopPort>${jetty.dynamic.stop.port}</stopPort>
</configuration>
</execution>
</executions>
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/fcrepo/integration/SanityIT.java
Expand Up @@ -41,7 +41,7 @@ public class SanityIT {
* The server port of the application, set as system property by
* maven-failsafe-plugin.
*/
private static final String SERVER_PORT = System.getProperty("fcrepo.test.port");
private static final String SERVER_PORT = System.getProperty("fcrepo.dynamic.test.port");

/**
* The context path of the application (including the leading "/"), set as
Expand Down

0 comments on commit 967a5e6

Please sign in to comment.