Configurable namespace prefixes #22
Conversation
| @@ -0,0 +1,43 @@ | |||
| /** | |||
| * | |||
| */ | |||
There was a problem hiding this comment.
Is this empty javadoc comment required by checkstyle or our javadoc compilation? If not, we might as well remove it.
…ce properties file to test resources.
| sb.append("\n"); | ||
| sb.append("~~~~~~~~~~~~~~\n"); |
There was a problem hiding this comment.
Ouch! I thought it was helpful to be able to see this in the console, no?
There was a problem hiding this comment.
You should be able to copy the test resources into the jar artifact with something along the lines of:
https://maven.apache.org/plugins/maven-resources-plugin/plugin-info.html
Let me know if you need some help.
There was a problem hiding this comment.
Moving them to test means they're no longer on the classpath. :( Open to suggestions. Maybe download the file off of github and print it out?
There was a problem hiding this comment.
Our gihtub comments are crossing each other.
Sure, I'll try and ship it with the jar.
There was a problem hiding this comment.
The simpler alternative could be to leave the migration-bean.xml where it was and bring the namespaces.properties into the src/main/resources directory.
|
Squashed and merged in. |
Addresses FCREPO-1553