FCREPO-2064 standardize exception logging in JAXRS ExceptionMapper impls #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param error Throwable the intercepted error. | ||
| * @param logger Logger the logger to use | ||
| */ | ||
| public default void debugException(ExceptionDebugLogging context, Throwable error, Logger logger) { |
There was a problem hiding this comment.
This may be more a matter of style, but my preference would be to factor out logger into an abstract method Logger logger() and let it be implemented at greatest common factors in the mapper type-hierarchy.
|
@barmintor Are you done reacting to my comments? If so, I'll wait through this morning and if there are no other comments, I'll merge. |
|
@barmintor, as a note, I do not know a PR is ready for review until the associated JIRA item has been moved into the "Start Review" state. |
|
Moved to "Start Review" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.