Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root path to velocity context #1220

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

awoods
Copy link

@awoods awoods commented Aug 21, 2017

Add root path to velocity context

  • Remove ViewAssets
  • Remove variables to common.js and common.css locations

Resolves: https://jira.duraspace.org/browse/FCREPO-2534

@birkland
Copy link
Contributor

I've tested this behind an SSL termination proxy, and it does fix the problem where the browser refuses to load static assets.

There still seems to be an issue with the UI in Chrome, though. The Chrome flags the page as insecure, but does not explain why. It still proceeds with an https connection and renders the page well, but displays an "i" in the corner, instead of the green padlock. Firefox seems to be perfectly fine.

@awoods
Copy link
Author

awoods commented Aug 31, 2017

@birkland : This PR has already been committed to master.
Is the behavior you are seeing in this port of the fix in the 4.7-maintenance branch the same as what is seen in master?

@birkland
Copy link
Contributor

@awoods Yes. I think I'm going to approve this anyway (it's a definite improvement), but there's still something wrong in both master and maintenance-post-this-PR with respect to SSL compatibility of the UI. Unfortunately, I can't be any more specific than "it makes Chrome unhappy".

- Remove ViewAssets
- Remove variables to common.js and common.css locations

Resolves: https://jira.duraspace.org/browse/FCREPO-2534
@birkland
Copy link
Contributor

birkland commented Aug 31, 2017

Ah, found it!

Mixed Content: The page at 'https://localhost/fcrepo/rest/test' was loaded over a secure connection, but contains a form which targets an insecure endpoint 'http://localhost/fcrepo/rest/fcr:tx'. This endpoint should be made available over a secure connection.

@birkland birkland merged commit 43cb870 into fcrepo:4.7-maintenance Aug 31, 2017
@awoods awoods deleted the fcrepo-2534-4.7-maint branch August 31, 2017 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants