Make user identities available as URIs in kernel API. #1242
Conversation
There was a problem hiding this comment.
Very good work. I would only ask that you consider adding a default base URI to the one-click jar, and adding a logging statement whenever string userid is converted to a URI (since that could be dangerous, or create unintended consequences, in some circumstances).
| final ServletCredentials credentials = new ServletCredentials(request); | ||
| final FedoraSession session = repo.login(credentials); | ||
|
|
||
| // should thrown for unsupported digest algorithm sha256 |
There was a problem hiding this comment.
Is this the correct comment? I don't see how sha256 is involved
| // Construct the default URI for the user ID that is not a URI. | ||
| final String userAgentBaseUri = System.getProperty(USER_AGENT_BASE_URI_PROPERTY); | ||
| if (isNullOrEmpty(userAgentBaseUri)) { | ||
| throw new RepositoryConfigurationException("User agent base URI prioperty is missing." |
There was a problem hiding this comment.
This will make it required to provide a system property in order to support string user names. I believe this is a good thing. That being said, I think we should:
- mark this as a breaking change (since somebody who deploys Fedora may have to define this new property)
- provide a default base URI for the one-click jar in
fcrepo-webapp, since it is intended for demonstration purposes, and should be easy to use. (something likeinfo:fedora/local-user#) - log (either
DEBUGorINFO) that a URI was created from a string.
Would you be able to add the last two bullets to this PR, if you agree it is appropriate?
There was a problem hiding this comment.
@birkland Thanks. I've added the logging for the default user URI created. I tried to add the default URI to jetty-console-maven-plugin but I am not able to get it works. Do you have any working examples that can point me to?
Here is I was trying:
<configuration>
...
<systemProperties>
<systemProperty>
<name>fcrepo.auth.webac.userAgent.baseUri
<value>http://fedora.info/definitions/v4/person#
</systemProperty>
</systemProperties>
</configuration>
There was a problem hiding this comment.
@lsitu In the profile for one-click, there is a <properties> section that currently defines fcrepo.modeshape.configuration. Somehow, it influences the resulting jar in such a manner that results in that property being set when it is run. Glancing at the code, I have no idea how or why that works, but it does. Somehow, you'll need to do the same thing with fcrepo.auth.webac.userAgent.baseUri as happens with fcrepo.modeshape.configuration.
The first step would be to examine fcrepo-webapp/pom.xml and put fcrepo.auth.webac.userAgent.baseUri everywhere fcrepo.modeshape.configuration occurs.
There was a problem hiding this comment.
I wonder if any @fcrepo4/committers have any recollection on how the one-click jar gets the fcrepo.modeshape.configuration property, based on setting it in the pom.
There was a problem hiding this comment.
I believe this is where that's configured: https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-webapp/src/main/resources/spring/fcrepo-config.xml#L28-L30
There was a problem hiding this comment.
@birkland Oh, I think that's being set by the oneclick profile in pom.xml: https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-webapp/pom.xml#L494
There was a problem hiding this comment.
@escowles Right, it's set in the pom; but what is the mechanism by which that value affects the generated artifact in a manner such that Spring will know about its value? In other words, the value clearly gets recorded somewhere in the jar file. I'm wondering where, how, and by what mechanism does Spring discover it? (this won't block the PR, but I'm really curious)
There was a problem hiding this comment.
@lsitu Thanks, looks good
There was a problem hiding this comment.
@birkland Sorry to be so obtuse about this: I think that the Maven resources filtering does that part: https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-webapp/pom.xml#L499-L505
base uri to avoid the one click jar issue.
lsitu
force-pushed
the
feature/user_uri
branch
from
7c9864f
to
422a95f
Compare
Fixes #https://jira.duraspace.org/browse/FCREPO-2608
Make user identities available as URIs in kernel API through method getUserAgent().