Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong memory overflow check in ngx_http_upload_module.c #104

Open
sumit-kakadiya opened this issue Jun 29, 2018 · 0 comments
Open

wrong memory overflow check in ngx_http_upload_module.c #104

sumit-kakadiya opened this issue Jun 29, 2018 · 0 comments

Comments

@sumit-kakadiya
Copy link

In function ngx_http_upload_eval_state_path()
the following code
u->state_store_path = ngx_pcalloc(r->pool, sizeof(ngx_path_t));
if(u->store_path == NULL) {
return NGX_ERROR;
}

Shouldn't it be as follow?
u->state_store_path = ngx_pcalloc(r->pool, sizeof(ngx_path_t));
if(u->state_store_path == NULL) {
return NGX_ERROR;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant