Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for .tar.gz archives as input of govpp apigen #125

Closed
sknat opened this issue Apr 20, 2023 · 0 comments · Fixed by #130
Closed

support for .tar.gz archives as input of govpp apigen #125

sknat opened this issue Apr 20, 2023 · 0 comments · Fixed by #130
Assignees

Comments

@sknat
Copy link
Contributor

sknat commented Apr 20, 2023

It would be nice to be able to pass an archive as an input to the apigen cli, i.e. :

//go:generate go run go.fd.io/govpp/cmd/binapi-generator --gen rpc -o ./bindings --input ./somefile.tar.gz

Where ./somefile.tar.gz contains

core/
  ip_types.api.json
  ip.api.json
  ...
plugins/
  abf.api.json
  acl.api.json
  ...

In some cases, the api specification is exchanged as a compressed bundle,
having this feature would spare the caller the hassle to (decompress ; pass the temporary directory as input ; cleanup)

@sknat sknat added the feature New Feature label Apr 20, 2023
@ondrej-fabry ondrej-fabry self-assigned this Apr 28, 2023
@ondrej-fabry ondrej-fabry added enhancement and removed feature New Feature labels Apr 28, 2023
@ondrej-fabry ondrej-fabry linked a pull request May 26, 2023 that will close this issue
@sknat sknat closed this as completed in #130 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants