LDFLAG gets redefined in the code, though if it is set in the Makefile

[praveenfff]

Sometimes the libmemif.so can be generated at a custom path rather than in the standard path /usr/lib.

extras/libmemif/adapter.go
extras/libmemif/error.go

Has the definition of LDFLAGS in the code which redefines the one which is set from Makefile
#cgo LDFLAGS: -lmemif

Could you please make this flexible so that it can be set via Makefile

[ondrej-fabry]

I would like to note that the extras/libmemif is not maintained and most likely does not work at all anymore with any of the recent VPP releases.

There is however something similar implemented in the VPP repository that might provide the same functionality and it seems to be more recently updated: https://github.com/FDio/vpp/tree/master/extras/gomemif

P.S: I will update the README in the GoVPP's extras/libmemif to provide this info for users.

[praveenfff]

Hi, I dont find go.mod under golang directory. Could you please help in executing one example. Thanks, Praveen.

…

On Fri, Aug 19, 2022 at 6:38 PM Ondrej Fabry ***@***.***> wrote: I would like to note that the extras/libmemif is not maintained and most likely does not work at all anymore with any of the recent VPP releases. There is however something similar implemented in the VPP repository that might provide the same functionality and it seems to be active: - vpp/extras/libmemif - https://github.com/FDio/vpp/tree/master/extras/libmemif - vpp/extras/gomemif - https://github.com/FDio/vpp/tree/master/extras/gomemif P.S: I will update the README in the GoVPP's extras/libmemif to provide this info for users. — Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUV5ZCNIXAAVXRIS5LRJP7DVZ6BNTANCNFSM56PLVYZA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ondrej-fabry]

I know, the Go code in the VPP repository was not implemented according to any Go standards or workflows.

Try adding go.mod file manually.

[dwallacelf]

This Issue is stale as the gomemif codbase has been moved from the VPP repo to this repo. The issue does not exist in the currently maintained codebase.