-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Lenny faces ( ͡° ͜ʖ ͡°) #162
Comments
If you have a good source for them (with an appropriate license), then it should be easy to add. You can have a look at the existing extractors for examples. And it's already possible to add your own characters: https://github.com/fdw/rofimoji#custom-character-files-and-descriptions |
I'll close this issue for now. Please re-open if you have a good source for them. Or open a PR 😉 |
@fdw isn't good what I provided? Also I can't reopen anything closed by owner. |
There is already a way to add your own characters of any kind, and I already linked the relevant readme section. If you have questions about it, please ask them 🙂 Also, I'd look at a PR to add an extractor, if you want to write one. Please make sure that the license for the data is permissive enough. In this case, it seems the original source is https://github.com/w33ble/emoticon-data , which has a good license and should be easy to use, given that it's json.
Interesting, I didn't know that. Seems to be a GitHub setting and not something I can change. |
I wouldn't ask if it was not coming with its own issues. Each character of lenny face is treated as separate character. There's no way of quoting whole string. Test it. |
Then please describe your issue! In your original post, you just asked
and I answered both questions. How can I know that you tried it and had problems? In the original file you linked, the faces are separated from their description with tabs. However, |
rofimoji.mp4In theory quotations of objects and separating them with commas or semicolons would suffice.
Large? Agreed. But breaking? nah... Just make it backward compatible with old files. |
The problem seems to be exactly what I said: The file you linked still separates characters from descriptions with tabs, not spaces. Additionally, the one you used in the video has a space directly after the opening parens - that's why And there is currently no way of using something else as a separator.
Whatever character is chosen cannot be used anywhere else, especially not as a character itself (which is problematic, as
You're invited to try the change, but I fail to see how |
At least make space escapeable... with \ |
As I said, it's not just about parsing the file, but also about the communication with I'll think about it, but don't get your hopes up. |
I've finally tried to use a real csv format for the data files, which would be the first step to enable characters with spaces. However, the performance is much worse than with the simpler format currently used - loading a file now takes five times as long as before. If you try to open many Maybe I'll change my opinion at some point in the future, if there's a compelling reason. And I'm still willing to look at PRs. |
Could you add lenny faces, or at least possibility to plug your own emotes?
https://raw.githubusercontent.com/cspeterson/splatmoji/master/data/emoticons/emoticons.tsv
The text was updated successfully, but these errors were encountered: