Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build/test triggering for every PR and on the master branch #102

Closed
mbrukman opened this issue Jan 23, 2019 · 2 comments
Closed

Add build/test triggering for every PR and on the master branch #102

mbrukman opened this issue Jan 23, 2019 · 2 comments

Comments

@mbrukman
Copy link

It would be nice to have automated build/test run for every GitHub PR to ensure that new proposed changes aren't breaking the build.

It's also not clear what are the set of commands needed to run to ensure that a proposed change is not breaking anything, particularly given that there is code in Java, Go, and Python in a single repo.

Running the following command from an unmodified master branch:

make build-java

fails with:

[ERROR] Errors: 
[ERROR]   KafkaFeatureRowDeserializerTest.feast.source.kafka.deserializer.KafkaFeatureRowDeserializerTest » SessionExpired
[ERROR] Tests run: 112, Failures: 0, Errors: 1, Skipped: 0

If we had a build status badge on the README.md file that I could see the latest build status, it would help me to understand that this is an existing and known flaky/broken test, and it would incentivize others to help fix or disable this test to get to a green build.

@zhilingc
Copy link
Collaborator

@mbrukman Thanks for trying even with the limited documentation, a quickstart is in the works (as suggested in #98). The badges are a good idea!

We have automated (unit) testing happening for the java components here, and PRs can't be merged in unless the tests pass, but it seems like sometimes the automated merging breaks the build :/

@woop
Copy link
Member

woop commented Jan 24, 2019

Added a PR for the badge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants