Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue between v0.21.x and v0.28.x #3455

Closed
gbmarc1 opened this issue Jan 20, 2023 · 1 comment
Closed

Compatibility issue between v0.21.x and v0.28.x #3455

gbmarc1 opened this issue Jan 20, 2023 · 1 comment
Labels
kind/bug priority/p2 wontfix This will not be worked on

Comments

@gbmarc1
Copy link
Contributor

gbmarc1 commented Jan 20, 2023

The new entity_columns attribute was added to the FeitureView class after 0.21. When a newer version of Feast reads the 0.21.x registry, it does not populate the entity_columns attribute leading to downstream inconsistencies.

One such inconsistencies occurs when getting historical features from the BigQuery offline store. There are no entities and the resulting query does not behave properly.

Expected Behavior

It would be nice if we could read the 0.21.x registry from the 0.28.x version. The other way around could prove to be useful when migrating an organization from Feast 0.21 -> 0.28. We may update the registry to 0.28 but some jobs will still have a 0.21 dependency. I did not test the later but will do shortly and update the issue.

edit: It is possible to read the 0.28 registry with 0.21 code. 0.21 python sdk seems to work appropriately which is good news for migration.

Current Behavior

Reading the 0.21.x registry from the 0.28.x registry leads to unexpected behaviours that is due to an empty entity_columns attribute.

Steps to reproduce

  • Install 0.21.x
  • Apply the registry
  • Install 0.28.x
  • List all feature views -> entity_columns should be empty

Specifications

  • Version: 0.28.1 (Feast) - 0.21.1 (registry)
  • Platform:
  • Subsystem:

Possible Solution

TBD

@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 10, 2023
@stale stale bot closed this as completed Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug priority/p2 wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant