Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Login By Password Api #36

Merged
merged 13 commits into from Sep 22, 2022
Merged

✨ Login By Password Api #36

merged 13 commits into from Sep 22, 2022

Conversation

deleteLater
Copy link
Contributor

@deleteLater deleteLater commented Sep 20, 2022 •
edited

this pr contains these changes

  • setup MediatR & FluentValidation
  • setup api global exception handling middleware
  • implementation
  • unit tests
  • integration tests
  • consistent api response
  • api versioning

@deleteLater deleteLater self-assigned this Sep 20, 2022
@deleteLater
Copy link
Contributor Author

consistent api response need some modification

@deleteLater
refactor(api/common): consistent api response v2
1fbe1c6 
server should always return ErrorCode instead of error message

BREAKING CHANGE: api `login-by-password` response format changed
@deleteLater
test(api/common): use Verify to do snapshot testing
ebbe3f0
@deleteLater
refactor(api/common): consistent api response v3
112e358 
1. make ApiResponse generic
2. remove api action filter
these changes let us see actual api response in swagger
@deleteLater
test(api/common): add api exception tests
e599095
@deleteLater
refactor(api/common): use built-in ExceptionHandlerMiddleware
22e1564
@deleteLater
Copy link
Contributor Author

deleteLater commented Sep 22, 2022 •
edited

Additional changes:

  • setup snapshot testing
  • improvements for consistent api response
  • replace custom exception handling middleware with the built-in one
  • add api exception handling test

@deleteLater deleteLater merged commit d8a8701 into main Sep 22, 2022
@deleteLater deleteLater deleted the feat/login-by-password branch September 22, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deleteLater deleteLater

Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deleteLater