Rendering Lists can be expensive #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, review and merge AFTER TS |
Also updated all prop types to be const as necessary for required functionality to work with vue-tsc
rikbrowning
force-pushed
the
feature/menu-perf
branch
from
3d1b0d2
to
9da307d
Compare
jmillar-nanthealth
approved these changes
Apr 8, 2022
|
This has been merged externally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
I delayed rendering lists that appear in menus until after the menu has been asked to open. The only real benefit here is when a user would have multiple selects for example on a page, improves initial render speed.
Quite an impactful change but from what I can see everything is behaving as expected.