Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change localhost to 0.0.0.0 in Makefile #9

Closed
clsource opened this issue Aug 8, 2020 · 2 comments · Fixed by #11
Closed

Change localhost to 0.0.0.0 in Makefile #9

clsource opened this issue Aug 8, 2020 · 2 comments · Fixed by #11
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@clsource
Copy link

clsource commented Aug 8, 2020

In Makefile

env:
	echo '' > .env.development
	echo 'BASE_URL="http://localhost:8080"' >> .env.development
	echo 'BASE_PATH="$(CUR_DIR)/"' >> .env.development

Using localhost can have problems in certain configurations. (For example if you want to test the app in a different computer than your localhost e.g. 192.168.0.x).

More Info:

https://superuser.com/questions/949428/whats-the-difference-between-127-0-0-1-and-0-0-0-0
@tib tib added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 9, 2020
@tib
Copy link
Member

tib commented Aug 9, 2020

Yes, it'll be better with 0.0.0.0 do you want to submit a PR?

@clsource
Copy link
Author

clsource commented Aug 9, 2020

Sure :)

clsource added a commit to NinjasCL-archive/feather that referenced this issue Aug 9, 2020
@clsource
refactor(makefile): changed localhost to 0.0.0.0
0ccc5fa 
closes FeatherCMS#9
@clsource clsource mentioned this issue Aug 9, 2020
Merged
@tib tib closed this as completed in #11 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(makefile): changed localhost to 0.0.0.0 NinjasCL-archive/feather
2 participants
@clsource @tib