This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
Regenerating service doesn't work (deletes my schema additions) #4
Labels
Comments
|
Please post your src/servicename/servicename.schema.?s file. |
|
I have the exact same issue. Just following instructions step by step from https://generator.feathers-plus.com/get-started/, using TS. @eddyystop The file is exactly as presented on https://generator.feathers-plus.com/get-started/ page. After the edits: src/services/users/users.schema.ts Command `` Note all the "force" lines, including on the modified file users.schema.ts. And the file goes back to virgin state: |
|
Tried all steps with JS type (instead of TS), same issue, "Getting Started" page suggested edits to src/services/users/users.schema.js are wiped out. Regeneration is broken. package.json: package-lock.json: |
|
Hi, |
|
OK, I noticed @feahters-plus/cli has been updated over night, I did a npm i -g @feathers-plus/cli and still get the same non-error. I'm on windows. I'm going to start an Ubuntu Hyper-V instance and see what happens with node on it. |
|
My gist users.schema.js |
|
Same issue here |
|
@iva2k Try removing from your users.schema.ts file it shouldn't be there. |
|
Just a heads up, this problem also happens when using the generator to regenerate the app. Then changes to index.js will be overwritten as well. |
|
@iva2k your line https://generator.feathers-plus.com/get-started/#adding-your-code |
|
@harveychow please check my comment above. If an issue remains, please post the module having the issue. |
|
@pkej I assume you set The code samples in Get Started are optained while running apps from the examples/ folder. examples/js/04-model is how the app should look after the user schema is added. Why don't you copy that elsewhere, run I need to reproduce your situation as I have not been able to duplicate it, and the generator is already used in production. I need your feathers-gen-specs.json file. Plus any files you have added custom code to (likely only the schema file you already posted). What system are you running on? What is the version# in feathers-plus/cli/package.json? |
|
@eddyystop I don't have My understanding of the explanation is that the blocks //!code //!end are individual, and should only be removed from the edited ones. Is it incorrect understanding? BTW, I had the latest cli version at the time (previous update was fetched right after the project was setup though). However, with today's release v0.4.14 doing the "Getting started" from scratch works past the re-generate step, all edits are kept intact. Not sure which part fixed it, but it works now. Even with Can close the issue? What was the fix (just curious)? |
|
The custom code extraction, default/custom code insertion module hasn't been touched for months. The only recent changes in service.schema.?s involved
The f+/generator-feathers-plus tests are rather OCD. They should have caught should a blatant problem. They compare the generation of multiple "apps" at the character level. Run So I'm a bit confused. You likely started using the generator while I was ill last week, maybe some testing was skipped. |
|
Please install the latest f+/cli if you have any of the issues mentioned here. |
|
I'm closing this issue based on iva2k's comment. Please open a new issue if the problem reoccurs. Thanks all. |
|
@eddyystop must be that, as I did start with f+/cli last week. Cool thing BTW that f+/cli with TS and regen and GraphQL. Should be in the standard feathers/cli in my opinion. |
|
It works brilliantly after the latest update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce
(First please check that this issue is not already solved as described
here)
I'm following the Get Started-tutorial. When updating the users model by updating the users.schema.js file and running feathers-plus generate service "nothing" happens, my changes are removed.
I'm using js and the following options:
Exact code as in the Feathers Models adding the Feathers Model.
Expected behavior
The users.schema.js file should keep the schema changes I added when regenerating the service and fill in the other modules. Command used:
feathers-plus generate serviceActual behavior
The users.schema.js file is reset to default empty state, nothing is generated.
System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
feathers-plus v0.4.11
Using generator version 0.2.16
NodeJS version:
node v8.10.0
Operating System:
Windows 10 Enterprise 1709 build 16299.431
(filed wrongly at this issue)
The text was updated successfully, but these errors were encountered: