Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

Want the default success/fail routes, not the sendFile #121

Closed
saiichihashimoto opened this issue Mar 24, 2016 · 1 comment
Closed

Want the default success/fail routes, not the sendFile #121

saiichihashimoto opened this issue Mar 24, 2016 · 1 comment
Labels
Milestone

Comments

@saiichihashimoto
Copy link
Contributor

As of v0.6.0 the setUpSuccessRedirect and setUpSuccessRedirect parameters have been removed in favor of checking if the routes are equal to the defaults. So now I can't use /auth/success or /auth/failure with my own routes and are forced to have it send the public/auth-success.html and public/auth-fail.html files. There should be an option of using those defaults without being forced to have those specific html files.

@ekryski
Copy link
Member

ekryski commented Mar 24, 2016

Ah 💩 I knew there was a reason I had that in there but then @daffl made me second guess. My bad. I'll do a patch release for this, along with #122.

@ekryski ekryski added the Bug label Mar 24, 2016
@ekryski ekryski modified the milestone: 0.7 Mar 26, 2016
@ekryski ekryski mentioned this issue Mar 30, 2016
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants