Use attributes exclude

[DaddyWarbucks]

Sequelize allows you to exclude attributes by providing an object to attributes instead of an array.
See: https://sequelize.org/v5/manual/querying.html

But the following line overwrites q.attributes with the filter.$select

feathers-sequelize/lib/index.js

Line 134 in dccc6a0

if (filters.$select) {

This means that even if the user passed the following object

context.params.sequelize = {
  attributes: {
    exclude: ['myProp']
  }
}

The exclude will be totally overwritten with the filter.$select

Instead the code should be updated to something like

if (filters.$select) {
  if (!q.attributes) {
    q.attributes = filters.$select
  } else if (Array.isArray(q.attributes)) {
    q.attributes = [...q.attributes, ...filters.$select];
  } else {
    q.attributes = {
      ...q.attributes,
      include: filters.$select
    }
  }
}

NOTE: I have not actually tested this but stumbled across it while working on something. I will write a test to confirm and make a PR shortly

[DaddyWarbucks]

Closing this issue. The comments made above are true. When using $select it does totally overwrite the attributes property. But, that makes sense because you would never really use both select and exclude at the same time.

As a note to future readers. If you need to use sequelize.attributes, do not also use query.$select.