Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Custom method definitions are effecting other methods #248

Closed
AshotN opened this issue Dec 9, 2022 · 1 comment
Closed

Bug: Custom method definitions are effecting other methods #248

AshotN opened this issue Dec 9, 2022 · 1 comment
Labels
Milestone

Comments

@AshotN
Copy link
Contributor

AshotN commented Dec 9, 2022

Describe the bug
I have a user service with a few custom methods. If I try to add docs for the custom methods it overwrites the user POST method and

To Reproduce

  docs: {
        operations: {
          verifySignupToken: {
            description: 'Verifies the users email address by form of long or short token',
            'parameters[0]': {
              description: 'Long version of token, would be embedded in a link',
              in: 'query',
              name: 'longToken',
              example: '75e69439-99e3-4179-abed-312914a15a1f',
              schema: {
                type: 'string'
              }
            },
            'parameters[1]': {
              description: 'Short version of token, would be included in email',
              in: 'query',
              name: 'shortToken',
              example: 'R5SIK0',
              schema: {
                type: 'string'
              }
            }
          },
          verifyResetToken: {
            description: 'Verifies the users request for a password reset by form of long or short token',
            'parameters[0]': {
              description: 'Long version of token, would be embedded in a link',
              in: 'query',
              name: 'longToken',
              example: '75e69439-99e3-4179-abed-312914a15a1f',
              schema: {
                type: 'string'
              }
            },
            'parameters[1]': {
              description: 'Short version of token, would be included in email',
              in: 'query',
              name: 'shortToken',
              example: 'R5SIK0',
              schema: {
                type: 'string'
              }
            },
            'parameters[2]': {
              in: 'query',
              name: 'newPassword',
              schema: {
                type: 'string'
              }
            }
          }
        },
        securities: enabledMethods
      }
    })

image

Here for example it get's the correct description but the incorrect params
image

System configuration
Tell us about the applicable parts of your setup.

  • "feathers-swagger": "^3.0.0-pre.0",
  • "@feathersjs/feathers": "^5.0.0-pre.33",,
@AshotN AshotN added the bug label Dec 9, 2022
@Mairu Mairu added this to the v3.0.0 milestone Dec 11, 2022
@Mairu
Copy link
Collaborator

Mairu commented Dec 11, 2022

Should be fixed in 3.0.0-pre.1

@Mairu Mairu closed this as completed Dec 11, 2022
@Mairu Mairu changed the title Bug: Custom method definitions are effecting other methods Bug: Custom method definitions are affecting other methods Mar 18, 2023
@Mairu Mairu changed the title Bug: Custom method definitions are affecting other methods Bug: Custom method definitions are effecting other methods Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants