Cannot read property 'on' of undefined - feathers-authentication-client

[MHerszak]

Hi there,

I am having an issue with a package called feathers-authentication-client.

I am getting the following error:

Cannot read property 'on' of undefined

which points to feathers-authentication-client/lib/passport.js:80

and results in -> socket.io.engine.on('upgrade', function () {.

I can only guess, engine seems to be undefined?

Module versions
"feathers-authentication-client": "^0.1.3",

NodeJS version:
v6.9.1

Operating System:
macOs Sierra -v 10.12.1

[ekryski]

I think the issue is that there is a race condition happening. It looks like engine isn’t assigned to the socket until a connection is established https://github.com/socketio/socket.io-client/blob/13002fb444e587ccdf2aa84711c8f0890d47b5ad/lib/manager.js#L208-L214.

So the event listener is registered before a connection has been established and therefore socket.engine may or may not be available yet. We need to move that handler to after the connection has occurred.

[ekryski]

@MHerszak mentioned that he changed autoConnect: false to autoConnect: true and it worked. Which supports my thinking. Will work on a fix this week.

[bertho-zero]

I had the same problem because I had to open the socket later, I had to make my app.configure('authentication') afterwards.

We could have something like this here (https://github.com/feathersjs/feathers-authentication-client/blob/master/src/passport.js#L55L77):

function socketUpgradeHandle() {
  socket.io.engine.on('upgrade', () => {
    debug('Socket upgrading');

    // If socket was already authenticated then re-authenticate
    // it with the server automatically.
    if (socket.authenticated) {
      const data = {
        strategy: this.options.jwtStrategy,
        accessToken: app.get('accessToken')
      };

      this.authenticateSocket(data, socket, emit)
        .then(this.setJWT)
        .catch(error => {
          debug('Error re-authenticating after socket upgrade', error);
          socket.authenticated = false;
          app.emit('reauthentication-error', error);
        });
    }
  });
}

if (socket.io) {
  if (socket.connected) {
    socketUpgradeHandle();
  } else {
    socket.on('connect', socketUpgradeHandle);
  }
}

[mihailp]

I have autoConnect: false and I face the same issue. Should this be fixed, or I need to solve it with some workaround like the guy above?

[marshallswain]

@mihailp This one's still open. The code here needs to be moved https://github.com/feathersjs/feathers-authentication-client/blob/master/src/passport.js#L56. I'm just not sure where, yet.

[daffl]

Should be closed via #20