Skip to content
This repository has been archived by the owner on Apr 23, 2019. It is now read-only.

Fix header casing #32

Merged
merged 2 commits into from
Mar 7, 2017
Merged

Fix header casing #32

merged 2 commits into from
Mar 7, 2017

Conversation

daffl
Copy link
Member

@daffl daffl commented Mar 7, 2017

@marshallswain
Copy link
Member

:shipit:

@ekryski
Copy link
Member

ekryski commented Mar 7, 2017

Yeah I think this should be fine. Server side Express lowercases it. The header sent from the client really should be Authorization as that is the HTTP standard. I don't think this will cause any side effects but can't be 100% certain. I'd say :shipit:

@daffl
Copy link
Member Author

daffl commented Mar 7, 2017

That's what I though. Sounds good. This repo is still 0.x so I'll just make it a 0.2 in case it does break something.

@daffl daffl merged commit 27f4fe9 into master Mar 7, 2017
@daffl daffl deleted the header-casing-23 branch March 7, 2017 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants