Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Log a warning if service.id is undefined or null #19

Closed
ekryski opened this issue May 4, 2017 · 0 comments · Fixed by #27
Closed

Log a warning if service.id is undefined or null #19

ekryski opened this issue May 4, 2017 · 0 comments · Fixed by #27

Comments

@ekryski
Copy link
Member

ekryski commented May 4, 2017

This came up in Slack and took a while to debug. Adding a warning here would make debugging a lot easier/faster.
marshallswain added a commit that referenced this issue Jun 22, 2017
@marshallswain
throw error if service.id is missing
fe2a2be 
Fixes #19

I implemented this as an error instead of a warning, because the plugin just won’t work as expected if it’s not set.  This makes it more obvious that it needs to be fixed right away.
@marshallswain marshallswain mentioned this issue Jun 22, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

throw error if service.id is missing feathersjs-ecosystem/authentication-local
1 participant
@ekryski