Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

LogoutTimer not being cleared correctly #532

Closed
wnxhaja opened this issue Jun 22, 2017 · 3 comments
Closed

LogoutTimer not being cleared correctly #532

wnxhaja opened this issue Jun 22, 2017 · 3 comments

Comments

@wnxhaja
Copy link
Contributor

wnxhaja commented Jun 22, 2017

I recently upgraded my feathers authentication from v1.2.2 to v1.2.4.

I am calling app.authenticate() on my client and expecting for the jwt expiry to update. I get the updated jwt token with the new expiry. But still I am being logout by the server because jwt token expires.

I look up the changelog and I found this fix #449. It is now using long-timeout in setting the logoutTimer but still using the old way of clearing timeout here. Then I change to lt.clearTimeout(logoutTimer) and it is now properly clearing the timeouts.

@marshallswain
Copy link
Member

@wnxhaja thank you for reporting this issue. Would you be able to make a PR with your changes?

@wnxhaja
Copy link
Contributor Author

wnxhaja commented Jun 22, 2017

Sure!

@daffl
Copy link
Member

daffl commented Jun 22, 2017

Closed via #534

@daffl daffl closed this as completed Jun 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants