This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Socket.io-client dependency import #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `import io from 'socket.io-client/socket.io';` to `import io from 'socket.io-client';` as otherwise there's an error when importing the dependency. (At least from what I have been encountering when switching our app from rest client to socket client). It's used as described in [official repo](https://github.com/socketio/socket.io-client#nodejs-server-side-usage) too.
|
It should probably be import io from 'socket.io-client/dist/socket.io';since the dist version is compatible with more module loaders. |
|
I'm not sure. Steal seems to be the only module loader that doesn't work with the |
marshallswain
pushed a commit
that referenced
this pull request
Mar 29, 2017
* Ben Awad just published a Full Example on YouTube You have a video example by Chris Pena, but unfortunately he never completed his video series... he never even got passed the first lecture video. It leaves a lot of people hanging, and does not help your adoption efforts. Ben Awad on the other hand, produced 8 videos, an entire series, on how to get up and running with FeatherJS. I have no affiliation with him, but I am going through his series, and it's top notch, and I recommend his videos to remove the friction from adopting a new library! I'm more likely to adopt feathers now, because of Ben Awad. I almost abandoned FeathersJS because Chris Pena's video series was incomplete. * git ignore for idea and webstorm * fixed wrong feathers-hooks-common package name * added feathers-errors to required installations * Revert some .gitignore changes from #325 * Suggested tweaks for #324 * Current Playlist Points to a Broken Link I changed it from this one (broken): https://www.youtube.com/playlist?list=PLN3n1USn4xlnulnnBGD2RMid_p7xVj9x to this one (working): https://www.youtube.com/playlist?list=PLN3n1USn4xlnulnnBGD2RMid_p7xVj9xU * Fix broken link (#332) * Install sequelize-cli globally * Fixed typo in populate hook doc * Typo fix in setUpdatedAt hook Small typo when using the `setUpdatedAt` hook, which was shown as `setCreatedAt`. * Using a different socket.io engine (#342) * Update socket-io.md * Update * Update socket-io.md * Update socket-io.md * Update socket-io.md * small typo ✏️ (#343) * Removed incorrect apostrophe (#346) * Missing , in example code for the copypasta people (#344) * Updated Showcases with Headstart's Native Apps * Update docs.feathersjs.com/services/readme.html (#355) * Update readme.md * Update readme.md * added axios section (#357) * Fix typo "fethers" => "feathers" (#358) * Adding feathers-socketcluster to showcase (#360) * Adding feathers-socketcluster to showcase * Wording fix. * Update feathers.md (#362) Change `import io from 'socket.io-client/socket.io';` to `import io from 'socket.io-client';` as otherwise there's an error when importing the dependency. (At least from what I have been encountering when switching our app from rest client to socket client). It's used as described in [official repo](https://github.com/socketio/socket.io-client#nodejs-server-side-usage) too. * Update SECURITY.md * typo fix (#376) successfull -> successful. * updated link to hooks (#377) pointing to the new link * Remove some repository links * Update SUMMARY.md * Initial restructuring into API and guides * A bunch more docs for databases and hook * Some more documentation * Update menu GitBook plugin * Adding guides to see what TOC would look like (#388) * First final draft of all transport documentation * Updated The Basics and Chat guides to display properly. - The include-codeblock plugin is used to insert JS code into the guide page from external files. - include-codeblock refers to files in the repo's /example. - URL links to JS files and dirs refer to feathers-guide/example on GitHub. - So the 2 /example dirs must be kept the same. - I'm uncertain we can ever use just 1 /example as I may have had issues trying to get include-codeblock to refer to GitHub. - The working examples can be run from the feathers-guide repo, not from this feathers-docs repo. This keeps feathers-docs light. - I think that we can soon remove the Gitbook pages from feathers-guide and use it to store the /example dir. * Changes Guide section TOC as discussed - Using v3.0.0 of Feathers customized TOC plugin - Changed SUMMARY as required - Added styling to styles/website.css - >>> No idea how this affects printed docs - Bumped package.json version * adding a few more apps to the ecosystem page * Change required since can't push TOC plugin * Cleaning up help section (#397) * removing changelog. Moving contributing, faq, and help top level and into their own folders * minor content updates to cleanup nav * fixing some typos (#398) * Auk reorg styling (#399) * removing changelog. Moving contributing, faq, and help top level and into their own folders * adding a build command * adding some pages to finalize nav links * adding some updated styles * adding more styles * removing title on main page. Not needed with the image * Adding event and error API docs (#406) * Add documentation for database specific params options (#407) * Finalizing app and service API docs (#408) * Added db: service option to rethink docs (#413) * Added db: service option to rethink docs * Update rethinkdb.md * Attempting to simplify for ESL readers (#412) * Attempting to simplify for ESL readers * Messages will Include the entire user After re-reading the original, I think this is a better match for what it was saying. * Update start-server.md * Update start-server.md * Update * Update start-server.md * Update start-server.md * Update application.md * The word connection was misspelled (#416) * Auk reorg client (#424) * Fix typo “have to” -> “how to” * Client API Closes #422 * Add feathers-vuex to the Ecosystem page * Make ecosystem plugins more accessible (#427) * Make plugins more accessible This makes the Ecosystem plugins more accessible by bringing them into the left sidebar. The list is huge, so this is very helpful to see how amazing our community is. * Reorder plugins, separate client plugins * More documentation for trnasports, clients and Express stuff (#438) * Rename README.md to readme.md (#441) * [WIP] Auk reorg - Adding initial Auth docs (#402) * update the contributing guide * adding some auth docs * a wee bit of formatting * Document feathers-authentication server module (#443) * Document feathers-authentication server module * Auth API Docs * Added API for `app` methods. * Better format code snippets * Add note about server methods * First cut of the new chat guide (#442) * Add links above methods. * Fix guides in sidebar, add a tiny bit of padding * Additional authentication service docs * Add params to authentication service's create hook * Add authenticate description * Fix link in auth page * Add docs for auth middleware * typo fix * Add ToC for the Chat Guide * Use initial caps in Guide titles * Add a ToC to the guides page. * No initial caps in sidebar when it includes lowercase * Add a ToC to the API page Closes #423 * Add all common hooks to the API (#445) * Small change in the service API documentation * Add common hooks to API documentation * Fix API ToC links * typo fix * Add source links next to hook API docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
import io from 'socket.io-client/socket.io';toimport io from 'socket.io-client';as otherwise there's an error when importing the dependency. (At least from what I have been encountering when switching our app from rest client to socket client).It's used as described in official repo too.