fix: Merge httpStrategies and authStrategies option (#1308)

feathersjs · Apr 24, 2019 · afa4d55 · afa4d55
1 parent 12d48ee
commit afa4d55
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 11 deletions.
diff --git a/packages/authentication-client/test/integration/fixture.ts b/packages/authentication-client/test/integration/fixture.ts
@@ -14,7 +14,6 @@ export default (app: Application) => {
     entity: 'user',
     service: 'users',
     secret: 'supersecret',
-    httpStrategies: [ 'jwt' ],
     authStrategies: [ 'local', 'jwt' ],
     local: {
       usernameField: 'email',

diff --git a/packages/authentication-local/test/fixture.js b/packages/authentication-local/test/fixture.js
@@ -13,7 +13,6 @@ module.exports = (app = feathers()) => {
     service: 'users',
     secret: 'supersecret',
     authStrategies: [ 'local', 'jwt' ],
-    httpStrategies: [ 'jwt' ],
     local: {
       usernameField: 'email',
       passwordField: 'password'

diff --git a/packages/authentication-oauth/test/fixture.ts b/packages/authentication-oauth/test/fixture.ts
@@ -30,7 +30,7 @@ app.set('authentication', {
   secret: 'supersecret',
   entity: 'user',
   service: 'users',
-  httpStrategies: [ 'jwt' ],
+  authStrategies: [ 'jwt' ],
   oauth: {
     defaults: {
       transport: 'query'

diff --git a/packages/authentication/src/options.ts b/packages/authentication/src/options.ts
@@ -1,5 +1,4 @@
 export default {
-  httpStrategies: [],
   authStrategies: [],
   jwtOptions: {
     header: { typ: 'access' }, // by default is an access token but can be any type

diff --git a/packages/express/lib/authentication.js b/packages/express/lib/authentication.js
@@ -24,14 +24,14 @@ exports.parseAuthentication = (settings = {}) => {
       return next();
     }
 
-    const { httpStrategies = [] } = service.configuration;
+    const { authStrategies = [] } = service.configuration;
 
-    if (httpStrategies.length === 0) {
-      debug('No `httpStrategies` found in authentication configuration');
+    if (authStrategies.length === 0) {
+      debug('No `authStrategies` found in authentication configuration');
       return next();
     }
 
-    service.parse(req, res, ...httpStrategies)
+    service.parse(req, res, ...authStrategies)
       .then(authentication => {
         debug('Parsed authentication from HTTP header', authentication);
         merge(req, {

diff --git a/packages/express/test/authentication.test.js b/packages/express/test/authentication.test.js
@@ -116,9 +116,9 @@ describe('@feathersjs/express/authentication', () => {
       });
     });
 
-    it('errors when there are no httpStrategies', () => {
+    it('errors when there are no authStrategies', () => {
       const { accessToken } = authResult;
-      app.get('authentication').httpStrategies = [];
+      app.get('authentication').authStrategies = [];
 
       return axios.get('/dummy/dave', {
         headers: {
@@ -127,7 +127,7 @@ describe('@feathersjs/express/authentication', () => {
       }).then(() => assert.fail('Should never get here'))
       .catch(error => {
         assert.strictEqual(error.response.data.name, 'NotAuthenticated');
-        app.get('authentication').httpStrategies = [ 'jwt' ];
+        app.get('authentication').authStrategies = [ 'jwt', 'local' ];
       });
     });