chore(package): Move adapter tests into their own module (#1164)

BREAKING CHANGE: Removes adapter tests from @feathersjs/adapter-commons

.codeclimate.yml

@@ -37,7 +37,7 @@ plugins:
       count_threshold: 3
 exclude_patterns:	
   - "**/test/*"	
-  - "**/tests/*"	
+  - "**/adapter-tests/lib/*"	
   - "**/dist/*"	
   - "**/*.dist.js"	
   - "**/templates/*"

packages/adapter-commons/README.md

@@ -1,7 +1,7 @@
 # Feathers Adapter Commons
 
 [![Build Status](https://travis-ci.org/feathersjs/feathers.png?branch=master)](https://travis-ci.org/feathersjs/feathers)
-[![Dependency Status](https://img.shields.io/david/feathersjs/feathers.svg?style=flat-square&path=packages/commons)](https://david-dm.org/feathersjs/feathers?path=packages/commons)
+[![Dependency Status](https://img.shields.io/david/feathersjs/feathers.svg?style=flat-square&path=packages/adapter-commons)](https://david-dm.org/feathersjs/feathers?path=packages/adapter-commons)
 [![Download Status](https://img.shields.io/npm/dm/@feathersjs/adapter-commons.svg?style=flat-square)](https://www.npmjs.com/package/@feathersjs/adapter-commons)
 
 > Shared utility functions for Feathers adatabase adapters
@@ -13,7 +13,7 @@ This is a repository for handling Feathers common database syntax.
 
 ## Authors
 
-[Feathers contributors](https://github.com/feathersjs/commons/graphs/contributors)
+[Feathers contributors](https://github.com/feathersjs/adapter-commons/graphs/contributors)
 
 ## License
 

packages/adapter-tests/.npmignore

@@ -0,0 +1 @@
+test/

packages/adapter-tests/CHANGELOG.md

@@ -0,0 +1,5 @@
+# Change Log
+
+All notable changes to this project will be documented in this file.
+See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+

packages/adapter-tests/LICENSE

@@ -0,0 +1,22 @@
+The MIT License (MIT)
+
+Copyright (c) 2019 Feathers
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+

packages/adapter-tests/README.md

@@ -0,0 +1,22 @@
+# Feathers Adapter Tests
+
+[![Build Status](https://travis-ci.org/feathersjs/feathers.png?branch=master)](https://travis-ci.org/feathersjs/feathers)
+[![Dependency Status](https://img.shields.io/david/feathersjs/feathers.svg?style=flat-square&path=packages/adapter-tests)](https://david-dm.org/feathersjs/feathers?path=packages/adapter-tests)
+[![Download Status](https://img.shields.io/npm/dm/@feathersjs/adapter-commons.svg?style=flat-square)](https://www.npmjs.com/package/@feathersjs/adapter-commons)
+
+> Feathers shared database adapter test suite
+
+## About
+
+This is a repository that contains the test suite for the common database adapter syntax.
+
+
+## Authors
+
+[Feathers contributors](https://github.com/feathersjs/adapter-tests/graphs/contributors)
+
+## License
+
+Copyright (c) 2018 Feathers contributors
+
+Licensed under the [MIT license](LICENSE).

packages/adapter-commons/lib/tests/methods.js → packages/adapter-tests/lib/methods.js

@@ -52,6 +52,17 @@ module.exports = (test, app, errors, serviceName, idProp) => {
             'Got a NotFound Feathers error'
           );
         }
+
+        try {
+          await service.get(doug[idProp], {
+            query: { [idProp]: '568225fbfe21222432e836ff' }
+          });
+          throw new Error('Should never get here');
+        } catch (error) {
+          assert.ok(error instanceof errors.NotFound,
+            'Got a NotFound Feathers error'
+          );
+        }
       });
 
       test('.get + NotFound', async () => {
@@ -102,6 +113,17 @@ module.exports = (test, app, errors, serviceName, idProp) => {
             'Got a NotFound Feathers error'
           );
         }
+
+        try {
+          await service.remove(doug[idProp], {
+            query: { [idProp]: '568225fbfe21222432e836ff' }
+          });
+          throw new Error('Should never get here');
+        } catch (error) {
+          assert.ok(error instanceof errors.NotFound,
+            'Got a NotFound Feathers error'
+          );
+        }
       });
 
       test('.remove + multi', async () => {
@@ -181,6 +203,19 @@ module.exports = (test, app, errors, serviceName, idProp) => {
             'Got a NotFound Feathers error'
           );
         }
+
+        try {
+          await service.update(doug[idProp], {
+            name: 'Dougler'
+          }, {
+            query: { [idProp]: '568225fbfe21222432e836ff' }
+          });
+          throw new Error('Should never get here');
+        } catch (error) {
+          assert.ok(error instanceof errors.NotFound,
+            'Got a NotFound Feathers error'
+          );
+        }
       });
 
       test('.update + NotFound', async () => {
@@ -234,6 +269,19 @@ module.exports = (test, app, errors, serviceName, idProp) => {
             'Got a NotFound Feathers error'
           );
         }
+
+        try {
+          await service.patch(doug[idProp], {
+            name: 'id patched doug'
+          }, {
+            query: { [idProp]: '568225fbfe21222432e836ff' }
+          });
+          throw new Error('Should never get here');
+        } catch (error) {
+          assert.ok(error instanceof errors.NotFound,
+            'Got a NotFound Feathers error'
+          );
+        }
       });
 
       test('.patch multiple', async () => {