[Dove] v5 Migration Learnings and Feedback

[mrfrase3]

Howdy!

Thought I might make a discussion as a place for people to share their learnings/feedback/tips/tricks with migrating to v5.

I'll start with a few things:

• make sure you update feathers-sync because of this issue Needs update for Feathers v5 feathersjs-ecosystem/feathers-sync#166
• socket.io has reduced the max size of socket messages to lessen the effect of DoS attacks. This caught me off guard when we had background workers running on a dedicated processing instance all of a sudden having its connection silently dropped when it tried to do large data transfers. The default size was changed from 1e8 (100MB) to 1e6 (1MB) in version 3, you can override this to be higher or even lower with the following config:

app.configure(socketio({ maxHttpBufferSize: 1e8 }));

• I've been migrating from v3 which was generated with the feathers-plus cli, as a result, I copied adding the jsonSchema for each service to be in the src/services/example/example.schema.js file, I find this to be a nicer way to handle the data model than the src/models/example.model.js file, as everything to do with a service is now all in one place.
• I wanted to use the airbnb eslint rules for the codebase, as the old codebase got real messy with the default lax linting, although it was a bit of work converting what the cli generated. I wonder if it is worth considering implementing a more rigid lint standard on the cli code, with my vote obviously being with airbnb.
• I replaced the file in src/services/index.js with the following:

const requireDir = require('require-dir');
const flatten = require('flat');

const services = flatten(requireDir(__dirname, {
  recurse: true,
  filter: (path) => !path.includes('authentication') && (!path.includes('.js') || path.includes('.service.js')),
}));

module.exports = (app) => {
  Object.keys(services).filter((i) => /\.service$/.test(i)).forEach((i) => {
    app.configure(services[i]);
  });
};