Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve authentication client default storage initialization #1613

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

daffl
Copy link
Member

@daffl daffl commented Oct 9, 2019

In some cases browsers (like Brave when all cookies are blocked) throw an error when accessing window.localStorage. This pull request improves the initialization to return a fallback memory storage on any localStorage initialization error.

Closes #1344

@daffl daffl merged commit d7f5107 into master Oct 10, 2019
@daffl daffl deleted the default-storage branch October 10, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document using localStorage shim in certain private browsers
1 participant