Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between NotAuthenticated errors in @feathersjs/authentication-client #1668

Closed
sebastien-prudhomme opened this issue Nov 5, 2019 · 0 comments · Fixed by #2189
Closed

Comments

@sebastien-prudhomme
Copy link

Hi,

When using OAuth there are two kind of NotAuthenticated errors that are throwed by the @feathersjs/authentication-client module:

  • one with the message "No accessToken found in storage" that is not really an error but a failed try to authenticate with a previous token
  • one that is throwed because there is an error field found in the redirect (http://www.example.com/#error=myerrormessage)

It will be great to distinguish between these two errors so that we can give user some feedback when there is a problem in Oauth workflow but not when there is no token in its local storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants