fix(configuration): Fix handling of config values that start with . or .. but are not relative paths #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually relative paths; e.g. ".foo" or "..bar"
daffl
changed the title
daffl
pushed a commit
that referenced
this pull request
Oct 9, 2020
…r .. but are not actually relative paths; e.g. ".foo" or "..bar" (#2065) Co-authored-by: Brian Koehler <bkoehler@langara.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the problem where a config value that is not a relative path gets normalized
to an absolute path when it shouldn't be. For example, values like ".foo" and "..bar" are
not relative paths.
Not that I am aware of.
Not that I am aware of.