Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Get hooks to work reliably with custom methods #2714

Merged
merged 1 commit into from Aug 3, 2022

Conversation

daffl
Copy link
Member

@daffl daffl commented Aug 3, 2022

This pull request fixes an issue where all hooks and application level hooks did not work with custom methods. The fix was to assemble the list of hooks dynamically during runtime instead of relying on the static store. This is slightly less performant but can probably be improved if need be.

@daffl daffl changed the title fix(core): Make hooks reliably work with custom methods fix(core): Get hooks to work reliably with custom methods Aug 3, 2022
@daffl daffl merged commit 8d7e04a into dove Aug 3, 2022
@daffl daffl deleted the custom-all-hooks branch August 3, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant