fix(schema): Check for undefined value in resolveQueryObjectId resolver #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 5127272 |
packages/mongodb/src/resolvers.ts
Outdated
| @@ -19,6 +19,10 @@ export async function resolveQueryObjectId( | |||
| ): Promise<IdQueryObject<ObjectId>> | |||
| export async function resolveQueryObjectId(value: ObjectIdParam): Promise<ObjectId> | |||
| export async function resolveQueryObjectId(value: ObjectIdParam | IdQueryObject<ObjectIdParam>) { | |||
| if (value === undefined || value === null) { | |||
There was a problem hiding this comment.
I think this is a scenario where we can actually just do if (!value) since the value has to be a string or an object, and neither of those can be 0.
There was a problem hiding this comment.
I think this is ok. Otherwise it would still error if you pass null as the value.
There was a problem hiding this comment.
Oops, I already made the changes prior to reading this. Resubmitted.
daffl
changed the title
|
Great, thank you! Will go out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Insures that a undefined or null field within the mongodb objectId resolver (resolveQueryObjectId) doesn't throw an exception and returns undefined.