Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(koa): Make Koa app inspectable #3069

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix(koa): Make Koa app inspectable #3069

merged 1 commit into from
Feb 22, 2023

Conversation

daffl
Copy link
Member

@daffl daffl commented Feb 22, 2023

This pull request fixes an issue that didn't allow to console.log a Koa based Feathers application. The problem was that the util.inspect.custom symbol was not copied to the new application so it tried to serialise the non-serialisable Koa app.context.

Closes #3066

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for feathers-dove canceled.

Name Link
🔨 Latest commit 43466c5
🔍 Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/63f631ea0790f30008bfcd3f

@daffl daffl merged commit 4fbbfff into dove Feb 22, 2023
@daffl daffl deleted the koa-inspect branch February 22, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hooks Context toJSON() function fails in 5.0.0-pre.38
1 participant