Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport-commons): Fix dispatching of arrays #3075

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Feb 24, 2023

Equivalent change from #3073

Copy link
Member

@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional, non-issue in the test name. :shipit:

@@ -163,6 +163,25 @@ describe('socket commons utils', () => {
dispatcher('testing', dummyChannel, dummyHook, data2)
})

it('dispatches dispatch arrays properly', (done) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take out extra "dispatch"?

@daffl daffl merged commit 98fdda5 into dove Mar 8, 2023
@daffl daffl deleted the array-dispatch branch March 8, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants