Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication-local): Local Auth - Nested username & Password fields #3091

Merged

Conversation

eXigentCoder
Copy link
Contributor

@eXigentCoder eXigentCoder commented Mar 6, 2023

In my application, I store all the authentication related information related to the user in a nested object. This nested subobject includes for example, the last login time, the password hash & salt, last login IP address etc and in my case it is called _auth. The problem is that currently the library only allows you to confirgure the username and password fields for authentication to only be on the top level of the entity.
A test has been added for the nested field case and lint rules passing locally.

Summary

(If you have not already please refer to the contributing guideline as described
here
)

  • Tell us about the problem your pull request is solving. Please see above
  • Are there any open issues that are related to this? No
  • Is this PR dependent on PRs in other repos? No

If so, please mention them to keep the conversations linked together.

@eXigentCoder
Copy link
Contributor Author

Hey team, just wanted to check if you need anything further from me to get this merged in?

@daffl daffl changed the title Local Auth - Nested username & Password fields fix(authentication-local): Local Auth - Nested username & Password fields Jun 7, 2023
@daffl daffl merged commit d135526 into feathersjs:dove Jun 7, 2023
@daffl
Copy link
Member

daffl commented Jun 7, 2023

Apologies for the delay and thank you for the thorough pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants