Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Add PaginationParams to general find method of 'FeathersService' #3095

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix(core): Add PaginationParams to general find method of 'FeathersService' #3095

merged 1 commit into from
Mar 10, 2023

Conversation

fratzinger
Copy link
Member

For a not explicitely typed service, the Service uses the FeathersService type from @feathersjs/feathers. FeathersService extends ServiceMethods which does not support paginate param for find method. So service.find({ paginate: false }) throws because paginate is not defined in interface Params.

See:
Bildschirm­foto 2023-03-08 um 23 45 05

Bildschirm­foto 2023-03-08 um 23 46 18

@daffl daffl changed the title fix(feathers): add PaginationParams to general find method of 'FeathersService' fix(core): Add PaginationParams to general find method of 'FeathersService' Mar 10, 2023
@daffl daffl merged commit 8ebdcf5 into dove Mar 10, 2023
@daffl daffl deleted the fix/pagination-params-service-methods branch March 10, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daffl daffl daffl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fratzinger @daffl