Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knex): Only apply default order for MSSQL #3145

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Apr 5, 2023

Only MSSQL requires a default sort order. All other database should use the natural or an explicit sort order.

Closes #3047

Copy link
Member

@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@daffl daffl merged commit 28c2627 into dove Apr 5, 2023
4 checks passed
@daffl daffl deleted the knex-mssql-order branch April 5, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knex: Unnecessary default ORDER BY clause added in find()
2 participants