Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knex): Get by id and transactions should work with params.knex #3146

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

daffl
Copy link
Member

@daffl daffl commented Apr 5, 2023

This pull request makes sure that queries by id and transactions work when passing params.knex.

Closes #3084

Copy link
Member

@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@daffl daffl merged commit b172b5e into dove Apr 5, 2023
4 checks passed
@daffl daffl deleted the knex-create-query branch April 5, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service.get(id) looses the where clause if query created in hook
2 participants