Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memory): Fix memory adapter readme #3153

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

FossPrime
Copy link
Member

@FossPrime FossPrime commented Apr 8, 2023

The adapter is not initialized like stated in the ReadMe, it doesn't even export a function named service, or even have a default export.

This matters as it's used on the NPM page.

We could also copy the docs page to here... that would be slightly easier for users, by exactly one click.

@daffl daffl changed the title Memory readme is out of date and wrong fix(memory): Fix memory adapter readme Apr 10, 2023
@daffl daffl merged commit a9d826a into feathersjs:dove Apr 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants