fix(authentication-oauth): Update OAuth redirect to handle user requested redirect paths #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
approved these changes
May 5, 2023
daffl
changed the title
|
Great catch! Will go out with the next patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the redirect functionality for
authentication-oauth. If a user had setoriginsin their configuration, and attempted to redirect to a different page on the client side by using a link in the format ofoauth/<name>/?redirect=my/path?, the redirect would only send them to the path of the originmyorigin/#access_token.The problem was the variable the
separatorvariable used to determine how to build the resulting URL. An addition test was added to verify the issue. With the change, if the user has an origin ofhttp://localhost:8080and a frontend application that uses OAuth withoauth/<name>/?redirect=my/path, they will be redirected properly tohttp://localhost:8080/my/path?access_token.