feat(hooks): Performance improvements #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
changed the title
|
Nice! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
copyToSelfmethod. The main reason it was added was to have all inherited properties available directly on the hook context instead of the prototype chain so you will see them right away if youconsole.logthe context object. However, a performance analysis showed that this part is eating up over 60% of the overall hook runtime:Inherited properties (like
ctx.method) can still be accessed directly so this change won't have any actual breaking changes. In Feathers benchmarks this improved the Koa throughput from 33k requests/second to 39k and for Socket.io from 72k to ~83k requests/second.