Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add build script and publish a version for Deno #6

Merged
merged 2 commits into from Jan 10, 2020
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Jan 10, 2020

Since @feathersjs/hooks is written in TypeScript there is no reason for it to not work with Deno (a new JS/TypeScript runtime). Except that the TypeScript for Node and Deno module import syntax is not compatible. In order to import the module properly like

import { hooks } from 'https://unpkg.com/@feathersjs/hooks@0.1.0/deno/index.ts';

We need to rewrite the module names to add the .ts extension (which for not so great reasons gives a compiler error in normal TypeScript).

@daffl daffl merged commit f2b5697 into master Jan 10, 2020
@daffl daffl deleted the deno branch January 10, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant