feat: Add support for regular before, after and error hooks #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
changed the title
collect hooks util. Not hitting error hooks
|
Alright, got it sorted, the error hooks should've gone first. We still need to add docs. |
|
Awesome. Thanks for fixing that. I'll work on docs. |
marshallswain
force-pushed
the
collect-hooks
branch
from
b8b7f17
to
fd0f06c
Compare
This pulls over the code for Regular hooks from this PR: feathersjs/feathers#2483
daffl
added a commit
that referenced
this pull request
Nov 19, 2021
This pulls over the code for Regular hooks from this PR: feathersjs/feathers#2483 Co-authored-by: marshall_thompson2 <marshall_thompson2@apple.com> Co-authored-by: daffl <daff@neyeon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@daffl let's debug these error hooks this week.