Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move development and publishing to Deno #93

Merged
merged 17 commits into from
Nov 19, 2021
Merged

Conversation

marshallswain
Copy link
Member

@marshallswain marshallswain commented Nov 18, 2021

This PR holds the latest code including support for Regular Hooks and the collect utility.

marshall_thompson2 and others added 11 commits October 21, 2021 22:50
@marshallswain marshallswain changed the title Deno Port WIP: Deno Port Nov 18, 2021
@marshallswain marshallswain marked this pull request as draft November 18, 2021 17:16
@marshallswain
Copy link
Member Author

marshallswain commented Nov 19, 2021

The coverage report is just the Deno default, right now found here. It should percentage complete and the lines not tested. It's not a very ideal format, though. We could consider using a tool like this: https://github.com/azu/lcov-summary

The nyc format is ideal: https://github.com/feathersjs/hooks/runs/4253954204?check_suite_focus=true#step:6:60
But I don't see a way to make it happen with deno tools, yet.

@daffl daffl changed the title WIP: Deno Port feat: Move development and publishing to Deno Nov 19, 2021
@marshallswain marshallswain marked this pull request as ready for review November 19, 2021 05:44
@marshallswain marshallswain merged commit 9e47da2 into master Nov 19, 2021
@marshallswain marshallswain deleted the deno-port-2 branch November 19, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants