Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocationTransformer #199

Closed
stemey opened this issue Dec 20, 2018 · 3 comments
Closed

LocationTransformer #199

stemey opened this issue Dec 20, 2018 · 3 comments
Labels
discussion

Comments

@stemey
Copy link
Collaborator

stemey commented Dec 20, 2018

I would expect the LocationTransformer to return all consumerLocations for a given rootLocation and return the rootLocation for all consumerLocations. Also the names should reflect this bijective transformation more clearly like:

toRootLocation(consumerLocations: ConsumerLocation[]): RootLocation
fromRootLocation(rootLocation: RootLocation): ConsumerLocation[]
@unstubbable
Copy link
Member

The transformer never operates on all consumers at once. Why do you have theses expectations? And what is your perspective or point of view for having them?

@clebert clebert closed this as completed Jan 4, 2019
@stemey
Copy link
Collaborator Author

stemey commented Mar 22, 2019

Should we reopen this to support navigating to two custom lcoations?

@unstubbable
Copy link
Member

@stemey Let's discuss those details in #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clebert @unstubbable @stemey