Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Service - Documentation doesn`t match to demo #473

Closed
haugthom opened this issue Apr 12, 2019 · 3 comments · Fixed by #477
Closed

History Service - Documentation doesn`t match to demo #473

haugthom opened this issue Apr 12, 2019 · 3 comments · Fixed by #477

Comments

@haugthom
Copy link

The documentation (https://feature-hub.io/docs/guides/sharing-the-browser-history)
of the history-service doesn`t match the demo (https://github.com/sinnerschrader/feature-hub/tree/master/packages/demos/src/history-service).

The documentation part uses react-router but the demo doesn`t.
It seems not to work with react router.

Can you please update the demo and use react router as well in the demo.

@unstubbable
Copy link
Member

We will look into this.

@unstubbable
Copy link
Member

Can you please have a look whether the integration of React Router in the history-service-demo-react-router branch answers your questions regarding the usage of the History Service with React Router?

@haugthom
Copy link
Author

I will check, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants