Unimpliment coalesce from spark script and make necessary changes to spark runner #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sami1309
changed the title
Codecov Report
@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 61.58% 60.97% -0.61%
==========================================
Files 31 31
Lines 9188 9279 +91
==========================================
Hits 5658 5658
- Misses 3035 3126 +91
Partials 495 495
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sami1309
requested review from
ahmadnazeri and
sdreyer
and removed request for
ahmadnazeri
sdreyer
reviewed
Sep 15, 2022
|
@Sami1309 can you run this with the tests @ahmadnazeri wrote and verify those still work? |
sdreyer
approved these changes
Sep 17, 2022
sdreyer
pushed a commit
that referenced
this pull request
Sep 17, 2022
…spark runner (#454) * make changes to avoid needing coalesce * extend resource row count to work with multipart resources * add recursive file lookup to pyspark script * fix iterator issues and add test * fix issues with SQL transformation testing * comment out unecessary tests * fix file path issue * fix row count issue distinguishing on transformation or primary * change row skip for iteration to use built in function/skip files
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the .coalesce option called when saving resources in the spark script. This saves the resources in multiple parts instead of conjoining them into a single part. Implementing this requires changing how iterators parse through files and the functional definition of a resource in the offline store (so now a resource is defined as the parent directory containing all the parts, not the single parquet file)
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: