Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old API key in stage when release is cut #3044

Closed
1 of 4 tasks
Tracked by #137
patphongs opened this issue Jul 11, 2019 · 2 comments
Closed
1 of 4 tasks
Tracked by #137

Remove old API key in stage when release is cut #3044

patphongs opened this issue Jul 11, 2019 · 2 comments

Comments

@patphongs
Copy link
Member

patphongs commented Jul 11, 2019

Summary

What we're after:
The private API key name has changed. We need to remove the old FEC_WEB_API_KEY from stage when release is cut now that we're using FEC_WEB_API_KEY_PRIVATE.

Completion criteria

  • Update stage environment var for private key as noted above
  • Make sure stage and prod aren't using the same keys, set up new ones if needed
  • Delete the old private key variable FEC_WEB_API_KEY
  • Test to make sure the parts of the site that access the API do not break (Such as calendar, data sections, candidate and committee profile pages, etc.)
@lbeaufort
Copy link
Member

lbeaufort commented Jul 11, 2019

@patphongs here is the follow up task #3029 - the “private” keys are already in place in all three environments. If we waited to change the keys until deploy we would have a brief outage.

@lbeaufort lbeaufort changed the title Change private API key name in Stage when release is cut Remove old API key in stage when release is cut Jul 16, 2019
@patphongs
Copy link
Member Author

Closing, this is a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants